Nice! I guess we do have architecture guys here!
anyway, here's the answer to Skills Test Part 1
1.) The code closely resembles a factory method pattern... but mixed with the singleton flavor making it really unstructured. (nice catch cruizer!)
2.) the return statements really doesn't do anything at all since the operations are done internally(very good analogy punzie).
3.)this line Me.CreateClient(String.Empty, String.Empty, String.Empty) promotes redundancy... we dont need this anymore since the string are already initialized already as empty.
4.) there are no exposed constructors.(good job jokiz)
5.) the CreateClient could be the initialize method for the class.. but since it is private then there is no use for it.
6.) If its an actual singleton pattern, then.. we should have a static variable that would act as the instantiation object for the class just like what tuldoklambat has said.
any more additional analogy to the code?
Posted
Feb 08 2006, 06:49 AM
by
keithrull